Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spotless] Applying Google Code Format for legacy directory (pt 2/4) #20 #1989

Merged

Conversation

MitchellGale
Copy link
Contributor

@MitchellGale MitchellGale commented Aug 18, 2023

Description

Applies spotless for part of legacy directory in project. Sets checkstyle to not fail on failure for legacy directory.

Issues Resolved

#1101

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1989 (633f88f) into main (7e3a718) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1989   +/-   ##
=========================================
  Coverage     97.30%   97.30%           
  Complexity     4621     4621           
=========================================
  Files           407      407           
  Lines         11933    11933           
  Branches        826      826           
=========================================
  Hits          11611    11611           
  Misses          315      315           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
@MitchellGale MitchellGale marked this pull request as draft August 18, 2023 17:45
@MitchellGale MitchellGale marked this pull request as ready for review August 18, 2023 21:21
acarbonetto
acarbonetto previously approved these changes Aug 21, 2023
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
@Yury-Fridlyand
Copy link
Collaborator

Compilation fails

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
acarbonetto
acarbonetto previously approved these changes Aug 21, 2023
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
@Yury-Fridlyand Yury-Fridlyand merged commit 2201509 into opensearch-project:main Aug 21, 2023
21 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the dev/sl_GoogleJavaFormat20 branch August 21, 2023 22:26
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-1989-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 220150969209bc8eefbac44fa0fc2f3ebc461687
# Push it to GitHub
git push --set-upstream origin backport/backport-1989-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1989-to-2.x.

MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 22, 2023
 (opensearch-project#1989)

* Spotless apply for legacy pt 2

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* spotless apply

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Spotless apply for legacy pt 2

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* spotless apply

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* updated type

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* removed spotless

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* add spotless

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* removed extra test

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
@joshuali925
Copy link
Member

ported by #2016, removing backport failed label

@MitchellGale
Copy link
Contributor Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants