Added back tick and moved String builder declaration down.

Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
opensearch-project · Jul 22, 2022 · 1a7c927 · 1a7c927
1 parent 1fadb92
commit 1a7c927
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/common/src/main/java/org/opensearch/sql/common/utils/StringUtils.java b/common/src/main/java/org/opensearch/sql/common/utils/StringUtils.java
@@ -38,8 +38,6 @@ public static String unquoteText(String text) {
       return text;
     }
 
-    StringBuilder textSB = new StringBuilder();
-
     char enclosingQuote;
     char firstChar = text.charAt(0);
     char lastChar = text.charAt(text.length() - 1);
@@ -60,6 +58,8 @@ public static String unquoteText(String text) {
     char currentChar;
     char nextChar;
 
+    StringBuilder textSB = new StringBuilder();
+
     // Ignores first and last character as they are the quotes that should be removed
     for (int chIndex = 1; chIndex < text.length() - 1; chIndex++) {
       currentChar = text.charAt(chIndex);

diff --git a/core/src/test/java/org/opensearch/sql/common/utils/StringUtilsTest.java b/core/src/test/java/org/opensearch/sql/common/utils/StringUtilsTest.java
@@ -40,6 +40,8 @@ void unquoteTest() {
 
     assertEquals("hello'", unquoteText("'hello''"));
     assertEquals("don't", unquoteText("'don't'"));
+    assertEquals("hello`", unquoteText("`hello``"));
+    assertEquals("don\"t", unquoteText("\"don\"t\""));
 
   }