Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jar hell on failureaccess-1.0.1.jar #83

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

zane-neo
Copy link
Collaborator

Description

Fix jar hell on /Users/zaniu/Downloads/opensearch-3.0.0-SNAPSHOT/plugins/.installing-17217627975867998583/failureaccess-1.0.1.jar

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ins/.installing-17217627975867998583/failureaccess-1.0.1.jar

Signed-off-by: zane-neo <zaniu@amazon.com>
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (edf3150) 82.31% compared to head (1064929) 81.29%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/main/java/org/opensearch/agent/ToolPlugin.java 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #83      +/-   ##
============================================
- Coverage     82.31%   81.29%   -1.03%     
  Complexity      152      152              
============================================
  Files            12       12              
  Lines           871      882      +11     
  Branches        115      115              
============================================
  Hits            717      717              
- Misses           95      106      +11     
  Partials         59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit bc835a0 into opensearch-project:main Dec 29, 2023
15 of 16 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/skills/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/skills/backport-2.x
# Create a new branch
git switch --create backport/backport-83-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bc835a03f0a1545d17b829a2d60390a82c3babd9
# Push it to GitHub
git push --set-upstream origin backport/backport-83-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/skills/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-83-to-2.x.

dbwiddis pushed a commit to dbwiddis/skills that referenced this pull request Dec 29, 2023
…ins/.installing-17217627975867998583/failureaccess-1.0.1.jar (opensearch-project#83)
dbwiddis pushed a commit to dbwiddis/skills that referenced this pull request Dec 29, 2023
…ins/.installing-17217627975867998583/failureaccess-1.0.1.jar (opensearch-project#83)

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants