[Backport 2.x] Migrate alerting tools #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add search alerts tool Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add search monitors tool Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add param tests and number parsing error handling Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add for list-based params Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add error logs Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Fix isNumeric var Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Minor test coverage increase & cleanup Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Cover few edge cases when param parsing Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit 2f06f6f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90 and
zhichao-aws
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #76 +/- ##
============================================
+ Coverage 81.53% 82.04% +0.50%
- Complexity 85 118 +33
============================================
Files 8 10 +2
Lines 520 685 +165
Branches 70 94 +24
============================================
+ Hits 424 562 +138
- Misses 56 76 +20
- Partials 40 47 +7 ☔ View full report in Codecov by Sentry. |
ohltyler
approved these changes
Dec 28, 2023
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
(cherry picked from commit 2f06f6f) Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2f06f6f from #66.