Change job-scheduler plugin group to point to correct location #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zane-neo <zaniu@amazon.com>
zane-neo
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
============================================
+ Coverage 44.41% 46.08% +1.67%
- Complexity 30 31 +1
============================================
Files 6 6
Lines 358 358
Branches 42 42
============================================
+ Hits 159 165 +6
+ Misses 178 172 -6
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zane-neo <zaniu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
dhrubo-os
reviewed
Dec 25, 2023
| @@ -119,7 +119,7 @@ dependencies { | |||
|
|
|||
| // ZipArchive dependencies used for integration tests | |||
| zipArchive group: 'org.opensearch.plugin', name:'opensearch-ml-plugin', version: "${version}" | |||
| zipArchive group: 'org.opensearch.plugin', name:'opensearch-job-scheduler', version: "${version}" | |||
| zipArchive group: 'org.opensearch', name:'opensearch-job-scheduler', version: "${version}" | |||
There was a problem hiding this comment.
Can we add a comment why for job-scheduler it's different than ml-plugin
Signed-off-by: zane-neo <zaniu@amazon.com>
dhrubo-os
approved these changes
Dec 26, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 26, 2023
* Change job-scheduler plguin group to point to correct localtion Signed-off-by: zane-neo <zaniu@amazon.com> * Add publish task Signed-off-by: zane-neo <zaniu@amazon.com> * add dependency task to publishToStagingRepo Signed-off-by: zane-neo <zaniu@amazon.com> * Fix publishAllPublicationsToStagingRepository failure issue Signed-off-by: zane-neo <zaniu@amazon.com> * add comment to JS plugin path Signed-off-by: zane-neo <zaniu@amazon.com> --------- Signed-off-by: zane-neo <zaniu@amazon.com> (cherry picked from commit 37bbd3b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zane-neo
pushed a commit
that referenced
this pull request
Dec 27, 2023
…60) * Change job-scheduler plguin group to point to correct localtion * Add publish task * add dependency task to publishToStagingRepo * Fix publishAllPublicationsToStagingRepository failure issue * add comment to JS plugin path --------- (cherry picked from commit 37bbd3b) Signed-off-by: zane-neo <zaniu@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
…earch-project#56) (opensearch-project#60) * Change job-scheduler plguin group to point to correct localtion * Add publish task * add dependency task to publishToStagingRepo * Fix publishAllPublicationsToStagingRepository failure issue * add comment to JS plugin path --------- (cherry picked from commit 37bbd3b) Signed-off-by: zane-neo <zaniu@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change job-scheduler plugin group to point to correct location
Issues Resolved
Change job-scheduler plugin group to point to correct location
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.