add illegeal exception

Signed-off-by: xinyual <xinyual@amazon.com>
opensearch-project · Dec 26, 2023 · 9ecc0ce · 9ecc0ce
1 parent 29deb8c
commit 9ecc0ce
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/main/java/org/opensearch/agent/tools/PPLTool.java b/src/main/java/org/opensearch/agent/tools/PPLTool.java
@@ -17,6 +17,7 @@
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
+import org.apache.commons.lang3.StringUtils;
 import org.apache.commons.text.StringSubstitutor;
 import org.json.JSONObject;
 import org.opensearch.action.ActionRequest;
@@ -93,6 +94,9 @@ public <T> void run(Map<String, String> parameters, ActionListener<T> listener)
         parameters = extractFromChatParameters(parameters);
         String indexName = parameters.get("index");
         String question = parameters.get("question");
+        if (StringUtils.isBlank(indexName) || StringUtils.isBlank(question)) {
+            throw new IllegalArgumentException("Parameter index and question can not be null or empty.");
+        }
         SearchRequest searchRequest = buildSearchRequest(indexName);
         GetMappingsRequest getMappingsRequest = buildGetMappingRequest(indexName);
         client.admin().indices().getMappings(getMappingsRequest, ActionListener.<GetMappingsResponse>wrap(getMappingsResponse -> {
@@ -341,7 +345,7 @@ private String parseOutput(String llmOutput, String indexName) {
                 // Joining the string back together
                 ppl = String.join("|", lists);
             } else {
-                ppl = llmOutput;
+                throw new IllegalArgumentException("The returned PPL: " + llmOutput + " has wrong format");
             }
         }
         ppl = ppl.replace("`", "");