Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add ignore_hosts config option for auth failure listener (#4538) #4609

Merged

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jul 30, 2024

Backport #4538 to 2.x

…h-project#4538)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit bc92a89)
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 42.30769% with 15 lines in your changes missing coverage. Please review.

Project coverage is 65.38%. Comparing base (5baa3c4) to head (8d1a51a).

Files Patch % Lines
.../org/opensearch/security/auth/BackendRegistry.java 55.55% 6 Missing and 2 partials ⚠️
...ch/security/auth/limiting/AbstractRateLimiter.java 12.50% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #4609      +/-   ##
==========================================
- Coverage   65.41%   65.38%   -0.03%     
==========================================
  Files         316      316              
  Lines       22108    22132      +24     
  Branches     3572     3578       +6     
==========================================
+ Hits        14462    14472      +10     
- Misses       5856     5868      +12     
- Partials     1790     1792       +2     
Files Coverage Δ
...search/security/securityconf/impl/v7/ConfigV7.java 78.21% <ø> (ø)
...ch/security/auth/limiting/AbstractRateLimiter.java 63.63% <12.50%> (-29.23%) ⬇️
.../org/opensearch/security/auth/BackendRegistry.java 61.00% <55.55%> (-0.26%) ⬇️

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwperks can you add a comment on why manual backport was required?

@cwperks
Copy link
Member Author

cwperks commented Jul 31, 2024

@DarshitChanpura Added a comment to describe why manual backport was needed.

@DarshitChanpura DarshitChanpura merged commit 56b6ae4 into opensearch-project:2.x Jul 31, 2024
76 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants