-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.15] Revert "[Backport 2.x] Remove static metaFields list and get version-specific values from core" #4474
[2.15] Revert "[Backport 2.x] Remove static metaFields list and get version-specific values from core" #4474
Conversation
f2c4284
to
b02a480
Compare
Let's add some info around the reason for the reversion. This is to resolve a failure seen during release integ testing in the ISM plugin.
It was seen in CloseActionIT and OpenActionIT which have integration tests around opening and closing indices. We reproduced the NPE by closing and opening an index, but have not fully analyzed how the NPE affects FLS rules when re-opening an index. We plan to introduce this bug fix for FLS Includes rules in a future release and add an additional test case where a closed index is re-opened and searched upon by a user that is mapped to a role with FLS Includes rules. |
@DarshitChanpura Can you also update release notes? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.15 #4474 +/- ##
==========================================
- Coverage 65.37% 65.35% -0.03%
==========================================
Files 311 311
Lines 21868 21862 -6
Branches 3550 3550
==========================================
- Hits 14297 14288 -9
- Misses 5805 5806 +1
- Partials 1766 1768 +2
|
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Reverts #4412 as it is causing ISM plugin failures:
https://ci.opensearch.org/ci/dbc/integ-test/2.15.0/9978/linux/arm64/tar/test-results/8315/integ-test/index-management/with-security/stdout.txt
https://ci.opensearch.org/ci/dbc/integ-test/2.15.0/9978/linux/arm64/tar/test-results/8315/integ-test/index-management/with-security/local-cluster-logs/id-0/stdout.txt)
Relevant issue: #4475