Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Updates integTestRemote task to dynamically fetch common-utils version from build.gradle (#3122) #3135

Merged

Conversation

DarshitChanpura
Copy link
Member

(cherry picked from commit 46989b5)

Backports #3122

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…n from build.gradle (opensearch-project#3122)

Fixes integTestRemote task to dynamically fetch common-utils version
from build.gradle instead of hard-coding it in the shell script

* Category : Refactoring

* Why these changes are required?
A temporary fix (opensearch-project#3018) was added to resolve CI failures in RC
generation caused due to out-of-date common-utils version being used in
the sanity test.

Related to comment:
opensearch-project#3018 (comment)

**This changes addresses the issue permanently by modifying
integTestRemote task to fetch the common-utils version dynamically from
build.gradle, and prevent blocking RC builds in future due to such
issue**

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
(cherry picked from commit 46989b5)
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #3135 (6182ae6) into 2.x (e4c7201) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #3135      +/-   ##
============================================
- Coverage     62.19%   62.18%   -0.01%     
+ Complexity     3311     3310       -1     
============================================
  Files           265      265              
  Lines         19496    19496              
  Branches       3328     3328              
============================================
- Hits          12125    12124       -1     
+ Misses         5743     5742       -1     
- Partials       1628     1630       +2     

see 2 files with indirect coverage changes

@cwperks cwperks merged commit e79f961 into opensearch-project:2.x Aug 9, 2023
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants