[Backport 2.x] Use the getRedirectUrl from OSD to generate nextUrl
#2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* feat: consume the get redirect url function from osd core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: consume the get redirect url function from osd core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: failed unit test because of an invalid mocked request Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: failed unit test because of an invalid mocked request Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 371495b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
cliu123,
cwperks,
DarshitChanpura,
derek-ho and
RyanL1997
as code owners
derek-ho
approved these changes
Aug 15, 2024
DarshitChanpura
approved these changes
Aug 15, 2024
cwperks
approved these changes
Aug 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #2087 +/- ##
=======================================
Coverage 71.04% 71.04%
=======================================
Files 96 96
Lines 2604 2604
Branches 392 385 -7
=======================================
Hits 1850 1850
Misses 649 649
Partials 105 105 ☔ View full report in Codecov by Sentry. |
|
@SuZhou-Joe would you mind taking a look at the CI failures? |
|
Test failures are because this repo hasn't been version bumped to 2.17.0 yet. |
RyanL1997
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 371495b from #2072.