Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation]feat: update title and descriptions #2084

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Aug 13, 2024

Description

Add description and change titles of features in new left nav.

Category

Enhancement

Why these changes are required?

For UX consistancy.

What is the old behavior before changes and new behavior after changes?

Before

image

After

image

Issues Resolved

[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.17%. Comparing base (76c176a) to head (c31f454).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2084   +/-   ##
=======================================
  Coverage   71.17%   71.17%           
=======================================
  Files          96       96           
  Lines        2598     2598           
  Branches      387      380    -7     
=======================================
  Hits         1849     1849           
  Misses        649      649           
  Partials      100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@derek-ho derek-ho added the backport 2.x backport to 2.x branch label Aug 13, 2024
@cwperks cwperks merged commit a13b2e6 into opensearch-project:main Aug 13, 2024
20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 13, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit a13b2e6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho pushed a commit that referenced this pull request Aug 13, 2024
(cherry picked from commit a13b2e6)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants