Use smaller and compressed varients of buttons and form components #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
requested review from
cliu123,
cwperks,
DarshitChanpura,
derek-ho and
RyanL1997
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2079 +/- ##
=======================================
Coverage 71.17% 71.17%
=======================================
Files 96 96
Lines 2598 2598
Branches 387 387
=======================================
Hits 1849 1849
Misses 649 649
Partials 100 100 ☔ View full report in Codecov by Sentry. |
derek-ho
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Changes look good to me @AMoo-Miki ! Is there an issue related to this change? Also, could you add before and after screenshot/video of this change?
cwperks
approved these changes
Aug 6, 2024
Looks like it is just some minor UX changes, don't have any concerns with this change. @AMoo-Miki confirmed offline there is no open issue regarding this. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
…2079) * Use EuiSmallButton Signed-off-by: Miki <miki@amazon.com> * Use EuiSmallButton Signed-off-by: Miki <miki@amazon.com> * Use EuiSmallButtonIcon Signed-off-by: Miki <miki@amazon.com> * Use EuiSmallButtonEmpty Signed-off-by: Miki <miki@amazon.com> * Use EuiSmallButtonEmpty Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedFormRow Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedField* Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedField* Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedSelect and EuiCompressedSuperSelect Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedRadio and EuiCompressedRadioGroup Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedSwitch Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedEuiTextArea Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedComboBox Signed-off-by: Miki <miki@amazon.com> * Update snapshots and tests Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 76c176a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho
pushed a commit
that referenced
this pull request
Aug 6, 2024
…2079) (#2080) * Use EuiSmallButton * Use EuiSmallButton * Use EuiSmallButtonIcon * Use EuiSmallButtonEmpty * Use EuiSmallButtonEmpty * Use EuiCompressedFormRow * Use EuiCompressedField* * Use EuiCompressedField* * Use EuiCompressedSelect and EuiCompressedSuperSelect * Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup * Use EuiCompressedRadio and EuiCompressedRadioGroup * Use EuiCompressedSwitch * Use EuiCompressedEuiTextArea * Use EuiCompressedComboBox * Update snapshots and tests --------- (cherry picked from commit 76c176a) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace instances of
EuiButtonthat don't have an explicit sizing attribute toEuiSmallButton*.Replace instances of
Eui<form elements>that don't have density attributes toEuiCompressed<form elements>.Category
Enhancement
Why these changes are required?
UX
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.