Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue setting nextUrl on click of logout button #2040

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jul 16, 2024

Description

Opening up a Draft PR that shows a fixes an issue on logout for multiple authentication types (basic + OIDC). When a user clicks the logout button, they will logout of the respective IdP and then land back on the OSD login screen. When the user is on the login page, the url is supposed to contain a nextUrl param which contains the page that the user was most recently visiting in OSD when they explicitly click the logout button.

Category

Bug fix

Issues Resolved

Discovered while investigating: #1823

Testing

This will stay in draft until unit and functional tests are added

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.39%. Comparing base (c143bce) to head (1a47c48).

Files Patch % Lines
public/apps/account/utils.tsx 20.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2040   +/-   ##
=======================================
  Coverage   71.39%   71.39%           
=======================================
  Files          97       97           
  Lines        2650     2650           
  Branches      403      402    -1     
=======================================
  Hits         1892     1892           
  Misses        642      642           
  Partials      116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant