[Backport 2.x] CI fixes for adapting admin password change and fix the Cypress browser #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…er (#1596) * Add the random admin password flow Signed-off-by: Ryan Liang <jiallian@amazon.com> * Pass --headless=old Signed-off-by: Ryan Liang <jiallian@amazon.com> * Switch to firefox for cypress Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the typo of firefox driver Signed-off-by: Ryan Liang <jiallian@amazon.com> * Directly changed admin password into admin in ci Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 1e7b421)
RyanL1997
approved these changes
Oct 3, 2023
DarshitChanpura
requested changes
Oct 3, 2023
There was a problem hiding this comment.
Blocking this until opensearch-project/security#3414 is merged.
Codecov Report
@@ Coverage Diff @@
## 2.x #1598 +/- ##
=======================================
Coverage 66.18% 66.18%
=======================================
Files 93 93
Lines 2339 2339
Branches 312 317 +5
=======================================
Hits 1548 1548
Misses 722 722
Partials 69 69 |
DarshitChanpura
approved these changes
Oct 3, 2023
|
The PR is now unblocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1e7b421 from #1596