Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make security-analytics integTest stable #1005

Merged
merged 1 commit into from
May 3, 2024

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Apr 30, 2024

Description

this pr identifies flaky integ tests & make security-analytics integTest CI stable

Issues Resolved

#985
#965
#939

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@riysaxen-amzn
Copy link
Collaborator

can we update the description with what all tests, this PR will fix. Also I see, this one's failing in MacOS build

org.opensearch.securityanalytics.threatIntel.integTests.ThreatIntelJobRunnerIT > testCreateDetector_threatIntelEnabled_testJobRunner FAILED

praveensameneni
praveensameneni previously approved these changes May 1, 2024
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
@AWSHurneyt AWSHurneyt merged commit eea1908 into opensearch-project:main May 3, 2024
16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2024
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
(cherry picked from commit eea1908)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2024
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
(cherry picked from commit eea1908)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt added a commit that referenced this pull request May 4, 2024
* make security-analytics integTest stable (#1005)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
(cherry picked from commit eea1908)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Added missing import.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Removed unused import.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt added a commit that referenced this pull request May 4, 2024
* make security-analytics integTest stable (#1005)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
(cherry picked from commit eea1908)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Added missing import.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Removed unused import.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants