-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update url with data source id; redirect on reload if ds id not present; minor fixes #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt; minor fixes Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep and
riysaxen-amzn
as code owners
September 3, 2024 07:32
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
riysaxen-amzn
approved these changes
Sep 4, 2024
AWSHurneyt
approved these changes
Sep 4, 2024
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport-1125-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e55f421ee0f492925e0d211fd20b7f2b2615a677
# Push it to GitHub
git push --set-upstream origin backport-1125-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.17
# Create a new branch
git switch --create backport-1125-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e55f421ee0f492925e0d211fd20b7f2b2615a677
# Push it to GitHub
git push --set-upstream origin backport-1125-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.17 Then, create a pull request where the |
amsiglan
added a commit
to amsiglan/security-analytics-dashboards-plugin
that referenced
this pull request
Sep 4, 2024
…nt; minor fixes (opensearch-project#1125) * update url with data source id; redirect on reload if ds id not present; minor fixes Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * revert unwanted change Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
added a commit
that referenced
this pull request
Sep 4, 2024
* Update url with data source id; redirect on reload if ds id not present; minor fixes (#1125) * update url with data source id; redirect on reload if ds id not present; minor fixes Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * revert unwanted change Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * New home page related UI updates (#1129) * refactored code Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated overview page with new widgets; added getting started page Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
added a commit
to amsiglan/security-analytics-dashboards-plugin
that referenced
this pull request
Sep 4, 2024
…nt; minor fixes (opensearch-project#1125) * update url with data source id; redirect on reload if ds id not present; minor fixes Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * revert unwanted change Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
1 task
amsiglan
added a commit
that referenced
this pull request
Sep 4, 2024
* Add threat alerts card for Analytics (All) workspace use case (#1124) * add data source threat alerts card Signed-off-by: Joanne Wang <jowg@amazon.com> * refactor RULE_SEVERITY_OPTIONS Signed-off-by: Joanne Wang <jowg@amazon.com> * fix and run tests Signed-off-by: Joanne Wang <jowg@amazon.com> * updated based on comments and run yarn test Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> * Update url with data source id; redirect on reload if ds id not present; minor fixes (#1125) * update url with data source id; redirect on reload if ds id not present; minor fixes Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * revert unwanted change Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * New home page related UI updates (#1129) * refactored code Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated overview page with new widgets; added getting started page Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Joanne Wang <jowg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds logic for updating urls with id of the selected data source and also sets the active data source on reload for view only pages.
Also onboards threat intel related pages to Multi data source selection
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.