Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.3] Use front-end report generation instead of chromium #611

Merged
merged 5 commits into from
Jan 3, 2023
Merged

[Backport 2.3] Use front-end report generation instead of chromium #611

merged 5 commits into from
Jan 3, 2023

Conversation

rupal-bq
Copy link
Member

Description

2.3 remove chromium

Issues Resolved

#577

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

rupal-bq and others added 5 commits December 30, 2022 21:05
Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Increment version to 2.4.1-SNAPSHOT (#540)

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>

* --wip--

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add initial implementation of client reporting generation

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix url with basepath

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Update header footer height

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Update dialog text to not close dialog

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove console.log

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove unused components

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove chromium references

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add report generation error handling

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Minor refactors

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add postinstall patch to support safari for html2canvas

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add dompurify

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix build error

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove chromium from CI

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Update CI artifact name

Signed-off-by: Joshua Li <joshuali925@gmail.com>

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
…eneration

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
@rupal-bq rupal-bq marked this pull request as ready for review December 30, 2022 22:00
@rupal-bq rupal-bq requested a review from a team as a code owner December 30, 2022 22:00
@rupal-bq rupal-bq merged commit 4c4f8c3 into opensearch-project:2.3 Jan 3, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-611-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4c4f8c3939ee134606509a38a403e432ee53f7c0
# Push it to GitHub
git push --set-upstream origin backport/backport-611-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport/backport-611-to-2.0.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 3, 2023
)

* Bump version 2.3.1 (#500)

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Use front-end report generation instead of chromium (#586)

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Increment version to 2.4.1-SNAPSHOT (#540)

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>

* --wip--

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add initial implementation of client reporting generation

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix url with basepath

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Update header footer height

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Update dialog text to not close dialog

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove console.log

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove unused components

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove chromium references

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add report generation error handling

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Minor refactors

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add postinstall patch to support safari for html2canvas

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add dompurify

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix build error

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove chromium from CI

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Update CI artifact name

Signed-off-by: Joshua Li <joshuali925@gmail.com>

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix workflow

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix dompurify version for build

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
(cherry picked from commit 4c4f8c3)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 3, 2023
)

* Bump version 2.3.1 (#500)

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Use front-end report generation instead of chromium (#586)

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Increment version to 2.4.1-SNAPSHOT (#540)

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>

* --wip--

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add initial implementation of client reporting generation

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix url with basepath

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Update header footer height

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Update dialog text to not close dialog

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove console.log

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove unused components

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove chromium references

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add report generation error handling

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Minor refactors

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add postinstall patch to support safari for html2canvas

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add dompurify

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix build error

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove chromium from CI

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Update CI artifact name

Signed-off-by: Joshua Li <joshuali925@gmail.com>

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix workflow

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix dompurify version for build

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
(cherry picked from commit 4c4f8c3)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-611-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4c4f8c3939ee134606509a38a403e432ee53f7c0
# Push it to GitHub
git push --set-upstream origin backport/backport-611-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport/backport-611-to-2.4.

@rupal-bq rupal-bq deleted the 2.3-front-end-report-generation branch January 10, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants