Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport 1.3] Enable windows build (#561) #562

Merged
merged 1 commit into from
Dec 2, 2022
Merged

[backport 1.3] Enable windows build (#561) #562

merged 1 commit into from
Dec 2, 2022

Conversation

rupal-bq
Copy link
Member

@rupal-bq rupal-bq commented Dec 2, 2022

Description

Backport #561 to 1.3 branch

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* feat: enable windows and macos build (#504)

Signed-off-by: Derek Ho <dxho@amazon.com>

* Remove macos

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Remove macos from dashboards report

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix build

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Update setup node for linux

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Co-authored-by: Derek Ho <derek01778@gmail.com>
(cherry picked from commit 6efd7b1)
@rupal-bq rupal-bq requested a review from a team as a code owner December 2, 2022 21:38
@codecov-commenter
Copy link

Codecov Report

Merging #562 (6b9c2dd) into 1.3 (ad72033) will increase coverage by 2.80%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3     #562      +/-   ##
============================================
+ Coverage     74.57%   77.38%   +2.80%     
============================================
  Files            94       30      -64     
  Lines          4008     1910    -2098     
  Branches        612      383     -229     
============================================
- Hits           2989     1478    -1511     
+ Misses          885      429     -456     
+ Partials        134        3     -131     
Flag Coverage Δ
dashboards-reports 77.38% <ø> (+0.31%) ⬆️
reports-scheduler ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tsscheduler/model/GetAllReportInstancesResponse.kt
...sscheduler/action/GetAllReportDefinitionsAction.kt
...uler/model/ReportDefinitionDetailsSearchResults.kt
.../opensearch/reportsscheduler/model/BaseResponse.kt
...rtsscheduler/action/GetAllReportInstancesAction.kt
...portsscheduler/model/GetReportDefinitionRequest.kt
...tsscheduler/action/DeleteReportDefinitionAction.kt
...tsscheduler/action/UpdateReportDefinitionAction.kt
...heduler/action/UpdateReportInstanceStatusAction.kt
...portsscheduler/model/ReportDefinitionDetailsDoc.kt
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rupal-bq rupal-bq merged commit 26a4eb1 into opensearch-project:1.3 Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants