Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3.2] Restrict chromium requests #429

Merged

Conversation

joshuali925
Copy link
Member

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

joshuali925 and others added 8 commits June 16, 2022 10:05
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925 joshuali925 requested a review from a team as a code owner August 17, 2022 17:24
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #429 (c3f599b) into aos-1.3.2.0 (5b7c1e9) will decrease coverage by 0.02%.
The diff coverage is 67.92%.

@@                Coverage Diff                @@
##             aos-1.3.2.0     #429      +/-   ##
=================================================
- Coverage          72.86%   72.83%   -0.03%     
  Complexity           373      373              
=================================================
  Files                 94       94              
  Lines               3928     3968      +40     
  Branches             609      617       +8     
=================================================
+ Hits                2862     2890      +28     
- Misses               891      903      +12     
  Partials             175      175              
Flag Coverage Δ
dashboards-reports 77.06% <67.92%> (-0.16%) ⬇️
reports-scheduler 68.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t_definition_details/report_definition_details.tsx 70.87% <0.00%> (ø)
.../components/main/report_details/report_details.tsx 73.73% <0.00%> (ø)
...r/routes/utils/visual_report/visualReportHelper.ts 80.37% <60.60%> (-8.38%) ⬇️
...rt_definitions/report_settings/report_settings.tsx 81.14% <100.00%> (ø)
...ashboards-reports/server/routes/utils/constants.ts 100.00% <100.00%> (ø)
...ashboards-reports/server/utils/validationHelper.ts 92.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuali925 joshuali925 merged commit a60c08c into opensearch-project:aos-1.3.2.0 Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants