Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security based integration tests #59

Merged

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Jul 29, 2024

Description

Fix security based integration tests, now the security based integration tests are running with integTestWithSecurity only.

Issues Resolved

#39

Test

Here are the test steps for future references

  1. run ci-runner container
docker run -u root -it opensearchstaging/ci-runner:ci-runner-centos7-opensearch-build-v3 /bin/bash
  1. clone the opensearch-build repo
  2. Run the following command
PATH=/home/ci-runner/.nvm/versions/node/v18.19.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin JAVA_HOME=/opt/java/openjdk-21 ./test.sh integ-test manifests/2.16.0/opensearch-2.16.0-test.yml --component query-insights --paths opensearch=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.16.0/latest/linux/x64/tar
  1. To test the changes, push the local change to your private repo. Then change the __checkout__ function in src/git/git_repository.py like this.
 def __checkout__(self) -> None:
        self.execute_silent("git init", self.dir)
        self.execute_silent("git remote add origin https://github.com/ansjcy/query-insights.git", self.dir)
        self.execute_silent("git fetch --depth 1 origin 67af75afa5cb1945edea298a373d79265e4eb7ed", self.dir)
        self.execute_silent("git checkout FETCH_HEAD", self.dir)
        self.sha = self.output("git rev-parse HEAD", self.dir)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chenyang Ji <cyji@amazon.com>
@ansjcy ansjcy merged commit c7fb34d into opensearch-project:main Jul 29, 2024
17 of 18 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 29, 2024
Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit c7fb34d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 29, 2024
Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit c7fb34d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy pushed a commit that referenced this pull request Jul 29, 2024
(cherry picked from commit c7fb34d)

Signed-off-by: Chenyang Ji <cyji@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy pushed a commit that referenced this pull request Jul 29, 2024
(cherry picked from commit c7fb34d)

Signed-off-by: Chenyang Ji <cyji@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants