Replace JSON11-produced hex escape codes with unicode escape codes #879
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON11.stringify produces JSON5 documents with hex escape codes (`\x1b`), which aren't standard JSON and cause `JSON.parse` to error. When using JSON11, replace all `\xXX` escape codes with the JSON-compatible equivalent Unicode escape codes (`\u00XX`). Fixes opensearch-project/OpenSearch-Dashboards#7367. Signed-off-by: Will Jordan <will.jordan@gmail.com>
wjordan
requested review from
ananzh,
kavilla,
dblock,
VachaShah,
nhtruong,
harshavamsi and
timursaurus
as code owners
|
Thanks @wjordan |
Signed-off-by: Will Jordan <wjordan@users.noreply.github.com>
No, the json11 library writes JSON5 documents as expected, the bug is in the serialization code in this repo. See the added unit test which fails without this PR. A feature request for json11 to take an option to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since #784,
JSON11.stringifyproduces JSON5 documents with hex escape codes (\x1b), which aren't standard JSON and causeJSON.parseto error. When using JSON11 code path, this PR applies a fix to replace all\xXXescape codes with the JSON-compatible equivalent Unicode escape codes (\u00XX).This PR adds a unit test verifying the fix by ensuring a round-trip
s.deserialize(s.serialize(obj))with an object containing long numerals and ANSI escape sequences completes successfully without error.Issues Resolved
Fixes opensearch-project/OpenSearch-Dashboards#7367.
Check List
yarn run lintdoesn't show any errorsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.