Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing types in package.json for aws-v3 #810

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

iamandrewluca
Copy link
Contributor

@iamandrewluca iamandrewluca commented Jul 5, 2024

Description

Adds a reference in package.json for the aws-v3 types

Issues Resolved

Closes #771

Check List

  • New functionality includes testing.
  • All tests pass
  • Linter check was successfull - yarn run lint doesn't show any errors
  • Commits are signed per the DCO using --signoff
  • Changelog was updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andrei Luca <1881266+iamandrewluca@users.noreply.github.com>
Signed-off-by: Andrei Luca <1881266+iamandrewluca@users.noreply.github.com>
@nhtruong nhtruong merged commit 86c9f22 into opensearch-project:main Jul 7, 2024
66 of 67 checks passed
@iamandrewluca iamandrewluca deleted the patch-1 branch July 8, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][v2.8.0] aws-v3 import is missing type definitions
2 participants