-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCI] Type improvement and optional callback on empty
method
#451
Conversation
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Looks good. Needs USER_GUIDE and CHANGELOG updates pls. |
On its way! |
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a test that an empty pool can be emptied again, otherwise LGTM!
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-451-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8374dd66d5c3a80c88a78511c2b752453bc0b47f
# Push it to GitHub
git push --set-upstream origin backport/backport-451-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Description
Add more type safety
Make
empty
method'scallback
arg optionalAdd/fix tests for listed above
Issues Resolved
Closes #452
Check List
yarn run lint
doesn't show any errorsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.