Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI] Type improvement and optional callback on empty method #451

Merged
merged 28 commits into from
Mar 28, 2023

Conversation

timursaurus
Copy link
Collaborator

@timursaurus timursaurus commented Mar 24, 2023

Description

Add more type safety
Make empty method's callback arg optional
Add/fix tests for listed above

Issues Resolved

Closes #452

Check List

  • New functionality includes testing.
    • All tests pass
  • Linter check was successfull - yarn run lint doesn't show any errors
  • Commits are signed per the DCO using --signoff
  • Changelog was updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
@dblock
Copy link
Member

dblock commented Mar 24, 2023

Looks good. Needs USER_GUIDE and CHANGELOG updates pls.

@timursaurus
Copy link
Collaborator Author

Looks good. Needs USER_GUIDE and CHANGELOG updates pls.

On its way!

@timursaurus timursaurus marked this pull request as draft March 24, 2023 15:49
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
@timursaurus timursaurus marked this pull request as ready for review March 24, 2023 16:05
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
@nhtruong nhtruong added the CCI College Contributor Initiative label Mar 24, 2023
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
USER_GUIDE.md Outdated Show resolved Hide resolved
USER_GUIDE.md Outdated Show resolved Hide resolved
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
@timursaurus
Copy link
Collaborator Author

@dblock @nhtruong Any further comments or suggestions?

Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a test that an empty pool can be emptied again, otherwise LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
@dblock dblock merged commit 8374dd6 into opensearch-project:main Mar 28, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-451-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8374dd66d5c3a80c88a78511c2b752453bc0b47f
# Push it to GitHub
git push --set-upstream origin backport/backport-451-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-451-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x CCI College Contributor Initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [CCI] BaseConnectionPool's empty method's callback is always required
3 participants