Add 2PR approval to release workflow #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
gaiksaya
requested review from
ananzh,
kavilla,
seanneumann,
dblock,
VachaShah,
nhtruong and
harshavamsi
as code owners
harshavamsi
approved these changes
Mar 1, 2023
nhtruong
pushed a commit
to nhtruong/opensearch-js
that referenced
this pull request
May 5, 2023
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
nhtruong
pushed a commit
to nhtruong/opensearch-js
that referenced
this pull request
May 5, 2023
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Theo Truong <theotr@amazon.com>
nhtruong
pushed a commit
to nhtruong/opensearch-js
that referenced
this pull request
May 5, 2023
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
harshavamsi
pushed a commit
that referenced
this pull request
May 9, 2023
* Add 2PR approval to release workflow (#411) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Update documentation regarding 2PR approval process (#412) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> --------- Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
harshavamsi
pushed a commit
that referenced
this pull request
May 9, 2023
* Add 2PR approval to release workflow (#411) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Theo Truong <theotr@amazon.com> * Update documentation regarding 2PR approval process (#412) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Theo Truong <theotr@amazon.com> * Added release.JenkinsFile Signed-off-by: Theo Truong <theotr@amazon.com> --------- Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Theo Truong <theotr@amazon.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
harshavamsi
pushed a commit
that referenced
this pull request
May 9, 2023
* Add 2PR approval to release workflow (#411) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Update documentation regarding 2PR approval process (#412) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> --------- Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change retrieves the codeowner's list from .github/codeowners file and adds them as approvers for releasing opensearch-dsl-py.
Here is a sample issue that is created when this workflow runs: gaiksaya#1
Once approved, the workflow continues to run as usual.
Note: This approval duration is subject to the broader 72 hours timeout for a workflow.
Issues Resolved
related opensearch-project/opensearch-build#3111
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.