Add missing types for AwsSigv4SignerOptions.service

[magoz]

Description

2.2.0 added support for AOSS, but the types weren't updated.

Issues Resolved

Fixes #356
Fixes #366

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[harshavamsi]

Hi @magoz can you sign off your commit with -s to allow DCO to pass?

[dblock]

Will need a line in https://github.com/opensearch-project/opensearch-js/blob/main/CHANGELOG.md, too.
Also is there any way we can catch this type of stuff in CI?

[magoz]

I cannot seem to be able to sign off the initial commit. I followed the instructions, but when I git push --force-with-lease origin patch-1 I get AccessDenied.

I originally added the PR via the web interface, and I suspect it sees me as a different user when I push from my local machine.

I tried to revert, but it didn't help since all the commits in the PR must be signed.

Any advice on how to fix this? Should I create a new PR with the signed commit?
Apologies in advance for the mess, This is one of my first PRs to OSS.

[nhtruong]

@magoz Create a new branch, add the changes, commit with DCO, then create a new PR. See if that would work for ya.

[nhtruong]

@dblock TypeScript would catch this. This repo needs to be converted to TS and we can do that along with API code generation for this client.

[magoz]

It worked, @nhtruong! See #377 :-)
I've also updated the changelog.

[dblock]

@dblock TypeScript would catch this. This repo needs to be converted to TS and we can do that along with API code generation for this client.

Indeed! I found out that someone opened #269 a long time ago :)

[dblock]

@magoz maybe you want to attempt #269? :)