Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all elastic/elasticsearch/kibana references #125

Merged
merged 10 commits into from
Aug 20, 2021
Merged

Rename all elastic/elasticsearch/kibana references #125

merged 10 commits into from
Aug 20, 2021

Conversation

boktorbb
Copy link
Contributor

@boktorbb boktorbb commented Aug 13, 2021 •
edited
Loading

Signed-off-by: Bishoy Boktor boktorbb@amazon.com

Description

  • Renamed all elastic references to opensearch
  • Renamed all elasticsearch references to opensearch
  • Renamed all kibana references to opensearchDashboards
  • Removed any remaining x-elastic header code
  • Removed docs
  • Fixed formatting with linter
  • All tests pass

Github workflow was left alone

Screen Shot 2021-08-13 at 11 27 39 AM

Issues Resolved

Closes #124

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@boktorbb boktorbb added 🚀 M3 sub-task for milestone 3 📛 rename labels Aug 13, 2021
@boktorbb boktorbb added this to the M3 milestone Aug 13, 2021
VijayanB
VijayanB reviewed Aug 13, 2021
View reviewed changes
.ci/functions/imports.sh Outdated Show resolved Hide resolved
VijayanB
VijayanB reviewed Aug 13, 2021
View reviewed changes
.ci/jobs/defaults.yml Outdated Show resolved Hide resolved
kavilla
kavilla reviewed Aug 14, 2021
View reviewed changes
.ci/run-repository.sh Outdated Show resolved Hide resolved
kavilla
kavilla reviewed Aug 14, 2021
View reviewed changes
lib/Connection.js Outdated Show resolved Hide resolved
ananzh
ananzh reviewed Aug 16, 2021
View reviewed changes
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some space issues

docs/examples/proxy/api/autocomplete.js Outdated Show resolved Hide resolved
docs/examples/proxy/api/index.js Outdated Show resolved Hide resolved
lib/Connection.js Outdated Show resolved Hide resolved
lib/Helpers.js Outdated Show resolved Hide resolved
lib/Transport.js Outdated Show resolved Hide resolved
lib/Transport.js Outdated Show resolved Hide resolved
scripts/utils/generateDocs.js Outdated Show resolved Hide resolved
scripts/utils/generateDocs.js Outdated Show resolved Hide resolved
scripts/utils/generateDocs.js Outdated Show resolved Hide resolved
Bishoy Boktor added 3 commits August 19, 2021 18:32
Rename all elastic/elasticsearch/kibana references and clean up any r…
5b2d880 
…emaining x-pack resources

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Change opensearch-js reference back to elasticsearch-js since we're r…
1eda789 
…eferencing elastic

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Fix name mappings and spacing issues
762c01b 
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Change OSAPI to OpenSearchAPI
06a4cde 
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
VijayanB
VijayanB reviewed Aug 20, 2021
View reviewed changes
.ci/run-opensearch.sh Outdated Show resolved Hide resolved
Bishoy Boktor added 2 commits August 20, 2021 16:44
Remove docs
177cfc1 
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Removed unused .ci file
6d4e529 
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@boktorbb boktorbb requested a review from VijayanB August 20, 2021 17:10
VijayanB
VijayanB reviewed Aug 20, 2021
View reviewed changes
index.js Outdated Show resolved Hide resolved
VijayanB
VijayanB reviewed Aug 20, 2021
View reviewed changes
lib/Transport.js Outdated Show resolved Hide resolved
VijayanB
VijayanB reviewed Aug 20, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
VijayanB
VijayanB reviewed Aug 20, 2021
View reviewed changes
test/benchmarks/suite.js Outdated Show resolved Hide resolved
VijayanB
VijayanB reviewed Aug 20, 2021
View reviewed changes
test/unit/client.test.js Outdated Show resolved Hide resolved
VijayanB
VijayanB reviewed Aug 20, 2021
View reviewed changes
test/unit/client.test.js Outdated Show resolved Hide resolved
VijayanB
VijayanB reviewed Aug 20, 2021
View reviewed changes
yarn.lock Show resolved Hide resolved
Bishoy Boktor added 2 commits August 20, 2021 19:29
Address PR comments
29194da 
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Address PR comments
db9e3a0 
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@boktorbb boktorbb requested a review from VijayanB August 20, 2021 19:44
stockholmux
stockholmux suggested changes Aug 20, 2021
View reviewed changes
Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several little branding things, and references to things that should be gone.

api/types.d.ts Show resolved Hide resolved
api/new.d.ts Show resolved Hide resolved
lib/Serializer.js Outdated Show resolved Hide resolved
lib/Transport.js Outdated Show resolved Hide resolved
lib/Transport.js Outdated Show resolved Hide resolved
scripts/utils/clone-opensearch.js Outdated Show resolved Hide resolved
scripts/utils/generateDocs.js Outdated Show resolved Hide resolved
test/acceptance/product-check.test.js Outdated Show resolved Hide resolved
test/integration/README.md Outdated Show resolved Hide resolved
test/integration/README.md Outdated Show resolved Hide resolved
Remove compatibility check code and tests, and changed some minor ref…
4e77960 
…erences

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
stockholmux
stockholmux previously requested changes Aug 20, 2021
View reviewed changes
Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing.

test/integration/README.md Outdated Show resolved Hide resolved
Minor OpenSearch reference
33acf4c 
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
stockholmux
stockholmux approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

VijayanB
VijayanB approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@VijayanB VijayanB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@boktorbb boktorbb merged commit c56751a into opensearch-project:main Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stockholmux stockholmux stockholmux approved these changes

@VijayanB VijayanB VijayanB approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

Assignees
No one assigned
Labels
📛 rename 🚀 M3 sub-task for milestone 3
Projects
None yet
Milestone
M3
Development

Successfully merging this pull request may close these issues.

[M3] Rename and refactor all elastic references to opensearch
5 participants
@boktorbb @stockholmux @VijayanB @kavilla @ananzh