[2.15] Cypress Fix for few flaky tests in index-management dashboard plugin during Jenkins executions #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaptainDredge
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
Signed-off-by: Prabhat Sharma <ptsharma@amazon.com>
CaptainDredge
force-pushed
the
flaky-test
branch
from
e4861ce
to
f7d559e
Compare
CaptainDredge
changed the title
peterzhuamazon
approved these changes
Jun 19, 2024
74 tasks
peterzhuamazon
changed the title
zhongnansu
reviewed
Jun 21, 2024
| @@ -17,7 +17,7 @@ describe('Rollups', () => { | |||
| cy.visit(`${BASE_PATH}/app/home#/tutorial_directory/sampleData`); | |||
|
|
|||
| // Click on "Sample data" tab | |||
| cy.contains('Sample data').click({ force: true }); | |||
| cy.contains('Sample data', { timeout: 60000 }).click({ force: true }); | |||
There was a problem hiding this comment.
You don't need this line.
There's not en element contains text "Sample data" on that page ${BASE_PATH}/app/home#/tutorial_directory/sampleData. No matter how long you wait, it will fail because it won't find any element.
There was a problem hiding this comment.
@zhongnansu Am I missing something here? Isn't Sample data there(highlighted)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change reduces the possibility of failures of few flaky tests in IM dashboard
Flaky tests:
rollup_spec cypress test
transform_spec cypress test
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.