Fix Flaky Discover Table Tests #1377
Conversation
LDrago27
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao and
zhongnansu
as code owners
| ); | ||
| cy.waitForLoader(); |
There was a problem hiding this comment.
why did you change this? wait for loader is more reliable since it waits for a specific element and not just the an arbitrary time which can cause the test to become flakey
There was a problem hiding this comment.
While running the tests, I found that waiting for page load didn't make sense in few occasions. While applying the filter to a table the entire page doesn't reload. In those scenarios(using waitForLoader) instead of waiting for the number of entires to change in table , cypress picks up the older table result and the evaluation condition fails.
To avoid such scenarios I have put a wait time.
There was a problem hiding this comment.
@ashwin-pc Updated the PR to remove waits, instead added verification for hits which has resolved the previous issues.
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
peterzhuamazon
merged commit c8cbf04
into
opensearch-project:main
Signed-off-by: Suchit Sahoo <suchsah@amazon.com> (cherry picked from commit c8cbf04)
Description
Fix Flaky tests in Discover Table.
Without Security
discover_table.spec.js.mp4
With Security
discover_table.spec.js.mp4
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.