Add additional workflows to central promotion workflows #4753
Conversation
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
gaiksaya
requested review from
dblock,
peterzhuamazon,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
gaiksaya
changed the title
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
| steps { | ||
| script { | ||
| echo 'Invalidating cloudfront' | ||
| def version=params.RELEASE_VERSION.find(/\d/) |
There was a problem hiding this comment.
Can you change this to name major_version, or it will be pretty confusing.
| } | ||
| steps { | ||
| echo 'Triggering publish to maven workflow' | ||
| build job: 'publish-to-maven', wait: true, parameters: [ |
There was a problem hiding this comment.
@peterzhuamazon @prudhvigodithi Do we want to wait for maven? IMO let's not?
There was a problem hiding this comment.
I think if the previous validation failed, then wait or error out the run.
Else, I have no concerns on straight follow up with maven release.
There was a problem hiding this comment.
It will error out. Tested that. The motivation to set wait:false is because maven takes a lot of time. And we do not want to wait in the release call for that. Let me know if that is okay.
Thanks!
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4753 +/- ##
==========================================
+ Coverage 92.04% 92.29% +0.24%
==========================================
Files 193 193
Lines 6411 6411
==========================================
+ Hits 5901 5917 +16
+ Misses 510 494 -16 ☔ View full report in Codecov by Sentry. |
Description
This changed adds below workflows to central promotion workflow.
Also replaces the old jenkinsFile and test cases with new one.
The flow would look like below
Issues Resolved
closes #4750
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.