Removing code to cut search results of hybrid search in the priority queue #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Jain <varunudr@amazon.com>
vibrantvarun
changed the title
vibrantvarun
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es and
zhichao-aws
as code owners
|
Will wait for @martin-gaievski to review this PR. |
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
src/main/java/org/opensearch/neuralsearch/search/query/HybridAggregationProcessor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Varun Jain <varunudr@amazon.com>
|
please add a unit test for case when |
Signed-off-by: Varun Jain <varunudr@amazon.com>
martin-gaievski
approved these changes
Sep 4, 2024
|
Looks good to me, thanks Varun |
vibrantvarun
added
the
backport 2.x
naveentatikonda
approved these changes
Sep 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
…queue (#867) * Removing code to cut results in the priority queue Signed-off-by: Varun Jain <varunudr@amazon.com> * throw exception when from is not equal to 0 Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding TODO check Signed-off-by: Varun Jain <varunudr@amazon.com> * Move pagination validation of from condition to query phase searcher Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding integ test Signed-off-by: Varun Jain <varunudr@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com> (cherry picked from commit b8e2b35)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
…queue (#867) * Removing code to cut results in the priority queue Signed-off-by: Varun Jain <varunudr@amazon.com> * throw exception when from is not equal to 0 Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding TODO check Signed-off-by: Varun Jain <varunudr@amazon.com> * Move pagination validation of from condition to query phase searcher Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding integ test Signed-off-by: Varun Jain <varunudr@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com> (cherry picked from commit b8e2b35)
vibrantvarun
added a commit
that referenced
this pull request
Sep 4, 2024
…queue (#867) (#881) * Removing code to cut results in the priority queue Signed-off-by: Varun Jain <varunudr@amazon.com> * throw exception when from is not equal to 0 Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding TODO check Signed-off-by: Varun Jain <varunudr@amazon.com> * Move pagination validation of from condition to query phase searcher Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding integ test Signed-off-by: Varun Jain <varunudr@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com> (cherry picked from commit b8e2b35) Co-authored-by: Varun Jain <varunudr@amazon.com>
vibrantvarun
added a commit
that referenced
this pull request
Sep 4, 2024
…queue (#867) (#880) * Removing code to cut results in the priority queue Signed-off-by: Varun Jain <varunudr@amazon.com> * throw exception when from is not equal to 0 Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding TODO check Signed-off-by: Varun Jain <varunudr@amazon.com> * Move pagination validation of from condition to query phase searcher Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding integ test Signed-off-by: Varun Jain <varunudr@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com> (cherry picked from commit b8e2b35) Co-authored-by: Varun Jain <varunudr@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the code where we cut the results of hybrid search while fetching topDocs(). Due to this piece of code the user gets a perception that pagination works in hybrid search however it does not. Therefore, to make cx experience better I am removing it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.