increase the default epochs to 1000 for linear regression #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Zhang <xunzh@amazon.com>
ylwu-amzn
previously approved these changes
Aug 5, 2022
ylwu-amzn
reviewed
Aug 5, 2022
| @@ -58,7 +58,7 @@ public class LinearRegression implements Trainable, Predictable { | |||
| //RMSProp | |||
| private static final double DEFAULT_DECAY_RATE = 0.9; | |||
|
|
|||
| private static final int DEFAULT_EPOCHS = 10; | |||
| private static final int DEFAULT_EPOCHS = 1000; | |||
| private static final int DEFAULT_INTERVAL = -1; | |||
| private static final int DEFAULT_BATCH_SIZE = 1; | |||
There was a problem hiding this comment.
Can you help fix the hard coded issue in line 203
LinearSGDTrainer linearSGDTrainer = new LinearSGDTrainer(objective, optimiser, epochs, DEFAULT_INTERVAL, DEFAULT_BATCH_SIZE, seed);
There was a problem hiding this comment.
Sure, do you mean DEFAULT_INTERVAL, DEFAULT_BATCH_SIZE, seed these 3 hard coded ones?
Signed-off-by: Xun Zhang <xunzh@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #394 +/- ##
=========================================
Coverage 91.43% 91.43%
Complexity 528 528
=========================================
Files 59 59
Lines 1529 1529
Branches 122 122
=========================================
Hits 1398 1398
Misses 89 89
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ylwu-amzn
approved these changes
Aug 8, 2022
jngz-es
approved these changes
Aug 8, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 8, 2022
* increase the default epochs to 1000 for linear regression Signed-off-by: Xun Zhang <xunzh@amazon.com> * make more parameters configuration in linear regression Signed-off-by: Xun Zhang <xunzh@amazon.com> (cherry picked from commit b760180)
Zhangxunmt
added a commit
that referenced
this pull request
Aug 8, 2022
* increase the default epochs to 1000 for linear regression Signed-off-by: Xun Zhang <xunzh@amazon.com> * make more parameters configuration in linear regression Signed-off-by: Xun Zhang <xunzh@amazon.com> (cherry picked from commit b760180) Co-authored-by: Xun Zhang <xunzh@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 8, 2022
* increase the default epochs to 1000 for linear regression Signed-off-by: Xun Zhang <xunzh@amazon.com> * make more parameters configuration in linear regression Signed-off-by: Xun Zhang <xunzh@amazon.com> (cherry picked from commit b760180)
Zhangxunmt
added a commit
that referenced
this pull request
Aug 8, 2022
* increase the default epochs to 1000 for linear regression Signed-off-by: Xun Zhang <xunzh@amazon.com> * make more parameters configuration in linear regression Signed-off-by: Xun Zhang <xunzh@amazon.com> (cherry picked from commit b760180) Co-authored-by: Xun Zhang <xunzh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xun Zhang xunzh@amazon.com
Description
Increase the number of iteration for epochs to improve convergence of linear regression.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.