Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade djl version to 0.28.0 #2578

Merged
merged 3 commits into from
Jun 20, 2024
Merged

upgrade djl version to 0.28.0 #2578

merged 3 commits into from
Jun 20, 2024

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented Jun 19, 2024 •
edited
Loading

Description

upgrade djl version to 0.28.0

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env June 19, 2024 22:43 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env June 19, 2024 22:43 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env June 19, 2024 22:43 — with GitHub Actions Inactive
@rbhavna
upgrade djl version to latest 0.28.0
7e9a069 
Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env June 19, 2024 22:49 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env June 19, 2024 22:49 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env June 19, 2024 22:49 — with GitHub Actions Inactive
@rbhavna rbhavna changed the title upgrade djl version to 0.28.0 to fix CVE upgrade djl version to 0.28.0 Jun 19, 2024
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env June 19, 2024 23:27 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env June 19, 2024 23:27 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env June 19, 2024 23:27 — with GitHub Actions Inactive
b4sjoo
b4sjoo reviewed Jun 20, 2024
View reviewed changes
ml-algorithms/build.gradle
exclude group: "com.microsoft.onnxruntime", module: "onnxruntime"
}
def os = DefaultNativePlatform.currentOperatingSystem
//arm/macos doesn't support GPU
if (os.macOsX || System.getProperty("os.arch") == "aarch64") {
dependencies {
implementation "com.microsoft.onnxruntime:onnxruntime:1.14.0"
implementation "com.microsoft.onnxruntime:onnxruntime:1.16.3!!"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's ! means here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The !! syntax is used to enforce the exact version of a dependency in Gradle, ensuring that no other version is used in the build process, which can help avoid compatibility issues and ensure consistency across different builds.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b4sjoo https://docs.gradle.org/current/userguide/single_versions.html#ex-shorthand-notation-for-strict-dependencies

@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env June 20, 2024 02:36 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env June 20, 2024 02:36 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env June 20, 2024 02:36 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env June 20, 2024 02:36 — with GitHub Actions Inactive
@rbhavna rbhavna merged commit 01c85cb into opensearch-project:main Jun 20, 2024
10 of 12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 20, 2024
@rbhavna @github-actions
upgrade djl version to 0.28.0 (#2578)
5411d23 
* upgrade djl version to latest 0.28.0

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>

* force onnxruntime_gpu to 1.16.3

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

---------

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit 01c85cb)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 20, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 20, 2024
@rbhavna @github-actions
upgrade djl version to 0.28.0 (#2578)
853ed87 
* upgrade djl version to latest 0.28.0

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>

* force onnxruntime_gpu to 1.16.3

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

---------

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit 01c85cb)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 20, 2024
Merged
rbhavna added a commit that referenced this pull request Jun 20, 2024
@opensearch-trigger-bot @rbhavna
upgrade djl version to 0.28.0 (#2578) (#2580)
63aeaab 
* upgrade djl version to latest 0.28.0

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>

* force onnxruntime_gpu to 1.16.3

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

---------

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit 01c85cb)

Co-authored-by: Bhavana Ramaram <rbhavna@amazon.com>
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env June 20, 2024 03:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env June 20, 2024 03:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env June 20, 2024 03:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env June 20, 2024 03:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env June 20, 2024 03:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env June 20, 2024 03:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env June 20, 2024 04:45 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env June 20, 2024 04:45 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env June 20, 2024 04:45 — with GitHub Actions Inactive
@peterzhuamazon peterzhuamazon mentioned this pull request Jun 21, 2024
Closed
74 tasks
zane-neo pushed a commit that referenced this pull request Jul 4, 2024
@opensearch-trigger-bot @rbhavna
upgrade djl version to 0.28.0 (#2578) (#2579)
e42b753 
* upgrade djl version to latest 0.28.0

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>

* force onnxruntime_gpu to 1.16.3

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

---------

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit 01c85cb)

Co-authored-by: Bhavana Ramaram <rbhavna@amazon.com>
@b4sjoo b4sjoo added the v2.16.0 Issues targeting release v2.16.0 label Jul 26, 2024
opensearch-trigger-bot bot added a commit that referenced this pull request Oct 2, 2024
@opensearch-trigger-bot @github-actions
upgrade djl version to 0.28.0 (#2578) (#2580)
73f4216 
* upgrade djl version to latest 0.28.0

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>

* force onnxruntime_gpu to 1.16.3

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

---------

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit 01c85cb)

Co-authored-by: Bhavana Ramaram <rbhavna@amazon.com>
(cherry picked from commit 63aeaab)
dhrubo-os pushed a commit that referenced this pull request Oct 2, 2024
@opensearch-trigger-bot
upgrade djl version to 0.28.0 (#2578) (#2580) (#3043)
a7ac777 
* upgrade djl version to latest 0.28.0

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>

* force onnxruntime_gpu to 1.16.3

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

---------

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit 01c85cb)

Co-authored-by: Bhavana Ramaram <rbhavna@amazon.com>
(cherry picked from commit 63aeaab)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhuamazon peterzhuamazon peterzhuamazon left review comments

@dhrubo-os dhrubo-os dhrubo-os approved these changes

@b4sjoo b4sjoo b4sjoo approved these changes

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@samuel-oci samuel-oci Awaiting requested review from samuel-oci samuel-oci is a code owner

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.15 v2.16.0 Issues targeting release v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rbhavna @peterzhuamazon @dhrubo-os @b4sjoo @ylwu-amzn