Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport-2.x] Backport fix bedrock preprocess func #2537

Merged

Conversation

zane-neo
Copy link
Collaborator

@zane-neo zane-neo commented Jun 12, 2024

Description

backport #2495

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

zane-neo and others added 10 commits June 12, 2024 08:21
Signed-off-by: zane-neo <zaniu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
…ase.java

Co-authored-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
@zane-neo zane-neo changed the title Backport fix bedrock preprocess func [Backport-2.x] Backport fix bedrock preprocess func Jun 12, 2024
@ylwu-amzn ylwu-amzn merged commit 210903d into opensearch-project:2.x Jun 12, 2024
5 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 12, 2024
* Fix bedrock connector embedding generation issue

Signed-off-by: zane-neo <zaniu@amazon.com>

* format code

Signed-off-by: zane-neo <zaniu@amazon.com>

* add IT

Signed-off-by: zane-neo <zaniu@amazon.com>

* add ITs

Signed-off-by: zane-neo <zaniu@amazon.com>

* format code

Signed-off-by: zane-neo <zaniu@amazon.com>

* change input to fix number format exception in local

Signed-off-by: zane-neo <zaniu@amazon.com>

* Add log to identify the failure IT root cause

Signed-off-by: zane-neo <zaniu@amazon.com>

* Update plugin/src/test/java/org/opensearch/ml/rest/MLCommonsRestTestCase.java

Co-authored-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>

* address comments

Signed-off-by: zane-neo <zaniu@amazon.com>

* fix backport incompatibility

Signed-off-by: zane-neo <zaniu@amazon.com>

---------

Signed-off-by: zane-neo <zaniu@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit 210903d)
zane-neo added a commit that referenced this pull request Jun 12, 2024
* Fix bedrock connector embedding generation issue

Signed-off-by: zane-neo <zaniu@amazon.com>

* format code

Signed-off-by: zane-neo <zaniu@amazon.com>

* add IT

Signed-off-by: zane-neo <zaniu@amazon.com>

* add ITs

Signed-off-by: zane-neo <zaniu@amazon.com>

* format code

Signed-off-by: zane-neo <zaniu@amazon.com>

* change input to fix number format exception in local

Signed-off-by: zane-neo <zaniu@amazon.com>

* Add log to identify the failure IT root cause

Signed-off-by: zane-neo <zaniu@amazon.com>

* Update plugin/src/test/java/org/opensearch/ml/rest/MLCommonsRestTestCase.java

Co-authored-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>

* address comments

Signed-off-by: zane-neo <zaniu@amazon.com>

* fix backport incompatibility

Signed-off-by: zane-neo <zaniu@amazon.com>

---------

Signed-off-by: zane-neo <zaniu@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit 210903d)

Co-authored-by: zane-neo <zaniu@amazon.com>
opensearch-trigger-bot bot added a commit that referenced this pull request Oct 1, 2024
* Fix bedrock connector embedding generation issue

Signed-off-by: zane-neo <zaniu@amazon.com>

* format code

Signed-off-by: zane-neo <zaniu@amazon.com>

* add IT

Signed-off-by: zane-neo <zaniu@amazon.com>

* add ITs

Signed-off-by: zane-neo <zaniu@amazon.com>

* format code

Signed-off-by: zane-neo <zaniu@amazon.com>

* change input to fix number format exception in local

Signed-off-by: zane-neo <zaniu@amazon.com>

* Add log to identify the failure IT root cause

Signed-off-by: zane-neo <zaniu@amazon.com>

* Update plugin/src/test/java/org/opensearch/ml/rest/MLCommonsRestTestCase.java

Co-authored-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>

* address comments

Signed-off-by: zane-neo <zaniu@amazon.com>

* fix backport incompatibility

Signed-off-by: zane-neo <zaniu@amazon.com>

---------

Signed-off-by: zane-neo <zaniu@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit 210903d)

Co-authored-by: zane-neo <zaniu@amazon.com>
(cherry picked from commit 1c90e38)
dhrubo-os pushed a commit that referenced this pull request Oct 1, 2024
…3029)

* Fix bedrock connector embedding generation issue

Signed-off-by: zane-neo <zaniu@amazon.com>

* format code

Signed-off-by: zane-neo <zaniu@amazon.com>

* add IT

Signed-off-by: zane-neo <zaniu@amazon.com>

* add ITs

Signed-off-by: zane-neo <zaniu@amazon.com>

* format code

Signed-off-by: zane-neo <zaniu@amazon.com>

* change input to fix number format exception in local

Signed-off-by: zane-neo <zaniu@amazon.com>

* Add log to identify the failure IT root cause

Signed-off-by: zane-neo <zaniu@amazon.com>

* Update plugin/src/test/java/org/opensearch/ml/rest/MLCommonsRestTestCase.java

Co-authored-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>

* address comments

Signed-off-by: zane-neo <zaniu@amazon.com>

* fix backport incompatibility

Signed-off-by: zane-neo <zaniu@amazon.com>

---------

Signed-off-by: zane-neo <zaniu@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit 210903d)

Co-authored-by: zane-neo <zaniu@amazon.com>
(cherry picked from commit 1c90e38)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants