refactor: remove unnecessary act call

Signed-off-by: Lin Wang <wonglam@amazon.com>
opensearch-project · Aug 2, 2023 · 06becc2 · 06becc2
1 parent 5ffe695
commit 06becc2
Showing 1 changed file with 13 additions and 32 deletions.
diff --git a/public/components/monitoring/tests/use_monitoring.test.ts b/public/components/monitoring/tests/use_monitoring.test.ts
@@ -44,9 +44,7 @@ describe('useMonitoring', () => {
 
     await waitFor(() => result.current.pageStatus === 'normal');
 
-    act(() => {
-      result.current.searchByNameOrId('foo');
-    });
+    result.current.searchByNameOrId('foo');
     await waitFor(() =>
       expect(Model.prototype.search).toHaveBeenCalledWith(
         expect.objectContaining({
@@ -56,9 +54,7 @@ describe('useMonitoring', () => {
       )
     );
 
-    act(() => {
-      result.current.searchByStatus(['responding']);
-    });
+    result.current.searchByStatus(['responding']);
     await waitFor(() =>
       expect(Model.prototype.search).toHaveBeenCalledWith(
         expect.objectContaining({
@@ -68,13 +64,10 @@ describe('useMonitoring', () => {
       )
     );
 
-    act(() => {
-      result.current.resetSearch();
-    });
+    result.current.resetSearch();
     await waitFor(() => result.current.pageStatus === 'normal');
-    act(() => {
-      result.current.searchByStatus(['partial-responding']);
-    });
+
+    result.current.searchByStatus(['partial-responding']);
     await waitFor(() =>
       expect(Model.prototype.search).toHaveBeenCalledWith(
         expect.objectContaining({
@@ -97,11 +90,9 @@ describe('useMonitoring', () => {
       )
     );
 
-    act(() => {
-      result.current.handleTableChange({
-        sort: { field: 'name', direction: 'desc' },
-        pagination: { currentPage: 2, pageSize: 10 },
-      });
+    result.current.handleTableChange({
+      sort: { field: 'name', direction: 'desc' },
+      pagination: { currentPage: 2, pageSize: 10 },
     });
     await waitFor(() =>
       expect(Model.prototype.search).toHaveBeenCalledWith(
@@ -119,9 +110,7 @@ describe('useMonitoring', () => {
 
     await waitFor(() => expect(Model.prototype.search).toHaveBeenCalledTimes(1));
 
-    act(() => {
-      result.current.reload();
-    });
+    result.current.reload();
     await waitFor(() => expect(Model.prototype.search).toHaveBeenCalledTimes(2));
   });
 
@@ -187,9 +176,7 @@ describe('useMonitoring', () => {
       expect(result.current.pagination?.currentPage).toBe(2);
     });
 
-    act(() => {
-      result.current.searchByNameOrId('foo');
-    });
+    result.current.searchByNameOrId('foo');
 
     await waitFor(() => {
       expect(Model.prototype.search).toHaveBeenCalledTimes(3);
@@ -215,9 +202,7 @@ describe('useMonitoring', () => {
       expect(result.current.pagination?.currentPage).toBe(2);
     });
 
-    act(() => {
-      result.current.searchByStatus(['responding']);
-    });
+    result.current.searchByStatus(['responding']);
 
     await waitFor(() => {
       expect(Model.prototype.search).toHaveBeenCalledTimes(3);
@@ -273,9 +258,7 @@ describe('useMonitoring.pageStatus', () => {
 
     // Mock search function to return empty result
     mockEmptyRecords();
-    act(() => {
-      result.current.searchByNameOrId('foo');
-    });
+    result.current.searchByNameOrId('foo');
     await waitFor(() => expect(result.current.pageStatus).toBe('reset-filter'));
   });
 
@@ -287,9 +270,7 @@ describe('useMonitoring.pageStatus', () => {
 
     // assume result is empty
     mockEmptyRecords();
-    act(() => {
-      result.current.searchByStatus(['responding']);
-    });
+    result.current.searchByStatus(['responding']);
     await waitFor(() => expect(result.current.pageStatus).toBe('reset-filter'));
   });