-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 1.0.0 for BWC test #492
Remove 1.0.0 for BWC test #492
Conversation
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
@@ -14,7 +14,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
java: [ 11, 17 ] | |||
bwc_version : [ "1.0.0", "1.1.0", "1.2.4", "1.3.2", "2.0.0", "2.1.0" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why aren't we bumping to 1.0.1 instead of just removing 1.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the request from infra team is to use 1.1.0 as a lowest version, removing makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix that commit after 1.0.0 did not go into 1.0.1 release because 1.0.1 bundle is using 1.0.0 core + 1.0.0.0/1.0.1.0 plugins as a mix.
Codecov Report
@@ Coverage Diff @@
## main #492 +/- ##
=========================================
Coverage 84.04% 84.04%
Complexity 1019 1019
=========================================
Files 146 146
Lines 4188 4188
Branches 373 373
=========================================
Hits 3520 3520
Misses 492 492
Partials 176 176 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-492-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 57c54963e570fed7490d0e3d5a2e33bf73e061a1
# Push it to GitHub
git push --set-upstream origin backport/backport-492-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit 57c5496)
Signed-off-by: Junqiu Lei junqiu@amazon.com
Description
Remove 1.0.0 BWC and switch to version 1.1.0, related issue opensearch-project/OpenSearch#3001
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.