Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gradle version to 7.5 #472

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Bump Gradle version to 7.5 #472

merged 1 commit into from
Jul 29, 2022

Conversation

junqiu-lei
Copy link
Member

@junqiu-lei junqiu-lei commented Jul 28, 2022

Signed-off-by: Junqiu Lei junqiu@amazon.com

Description

Bump Gradle version to 7.5

Issues Resolved

#468

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
@junqiu-lei junqiu-lei added the Maintenance Add support for new versions of OpenSearch/Dashboards from upstream label Jul 28, 2022
@junqiu-lei junqiu-lei requested a review from a team July 28, 2022 16:55
@junqiu-lei junqiu-lei self-assigned this Jul 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #472 (fdac34b) into main (7501bfc) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #472      +/-   ##
============================================
- Coverage     84.09%   84.07%   -0.03%     
+ Complexity      979      978       -1     
============================================
  Files           140      140              
  Lines          4031     4031              
  Branches        362      362              
============================================
- Hits           3390     3389       -1     
- Misses          475      476       +1     
  Partials        166      166              
Impacted Files Coverage Δ
...c/main/java/org/opensearch/knn/index/KNNQuery.java 77.77% <0.00%> (-5.56%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@junqiu-lei junqiu-lei merged commit c40196b into opensearch-project:main Jul 29, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 29, 2022
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit c40196b)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-472-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c40196bc7958c37fa4a20670d60083e3c99c03c4
# Push it to GitHub
git push --set-upstream origin backport/backport-472-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-472-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 29, 2022
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit c40196b)
junqiu-lei added a commit that referenced this pull request Jul 30, 2022
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit c40196b)

Co-authored-by: Junqiu Lei <junqiu@amazon.com>
@heemin32 heemin32 added v2.2.0 and removed 2.2.0 labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Maintenance Add support for new versions of OpenSearch/Dashboards from upstream v2.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants