Revert "Makes sure KNNVectorValues aren't recreated unnecessarily when quantization isn't needed" #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveentatikonda
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
…n quantization isn't needed (opensearch-project#2133) (opensearch-project#2140)" This reverts commit ca6b03f. Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda
force-pushed
the
revert_2140
branch
from
49e2f61
to
95e7f09
Compare
vamshin
approved these changes
Sep 27, 2024
ryanbogan
approved these changes
Sep 27, 2024
naveentatikonda
merged commit b0d82b7
into
opensearch-project:2.17
94 of 95 checks passed
navneet1v
added a commit
to navneet1v/k-NN
that referenced
this pull request
Sep 28, 2024
…en quantization isn't needed (opensearch-project#2133) (opensearch-project#2140)" (opensearch-project#2161) This reverts commit b0d82b7. Signed-off-by: Navneet Verma <navneev@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit ca6b03f.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.