Add integration test for binary vector values #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
requested review from
heemin32,
navneet1v,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
jmazanec15
approved these changes
Sep 25, 2024
src/main/java/org/opensearch/knn/index/codec/KNN80Codec/KNN80DocValuesProducer.java
Outdated
Show resolved
Hide resolved
VijayanB
force-pushed
the
add-binary-tests
branch
from
e7cddc9
to
9be1447
Compare
VijayanB
deleted the branch
opensearch-project:feature/build-vector-ds-greedily
VijayanB
force-pushed
the
add-binary-tests
branch
from
9be1447
to
826555b
Compare
VijayanB
deleted the branch
opensearch-project:feature/build-vector-ds-greedily
VijayanB
force-pushed
the
add-binary-tests
branch
from
826555b
to
96eb17f
Compare
VijayanB
deleted the branch
opensearch-project:feature/build-vector-ds-greedily
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
add-binary-tests
branch
from
96eb17f
to
faee127
Compare
|
CI failure with flaky test #2169 |
navneet1v
approved these changes
Oct 1, 2024
VijayanB
merged commit d61e7d4
into
opensearch-project:feature/build-vector-ds-greedily
28 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add integration test for binary vector values
Related Issues
Part of #1942
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.