Introduce mode and compression param resolution #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazanec15
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
jmazanec15
force-pushed
the
mode-resolution-v2
branch
from
4511887
to
ca2fc1f
Compare
jmazanec15
force-pushed
the
mode-resolution-v2
branch
from
ca2fc1f
to
c86f03c
Compare
|
Code looks good to me. Waiting for CI to be successful |
jmazanec15
force-pushed
the
mode-resolution-v2
branch
from
697a51c
to
2c8b4d3
Compare
Adds mode and compression based parameter resolution. With this, if a user specifies the mode and/or compression params, we will create a default configuration with the aim of meeting those hints. Currently, it does not contain support for overriding any of the parameters. This will be taken in a future commit. Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15
force-pushed
the
mode-resolution-v2
branch
from
2c8b4d3
to
bb651a7
Compare
jmazanec15
force-pushed
the
mode-resolution-v2
branch
7 times, most recently
from
6fec016
to
2f9abde
Compare
Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15
force-pushed
the
mode-resolution-v2
branch
from
2f9abde
to
0332546
Compare
jmazanec15
commented
Sep 5, 2024
| @@ -95,6 +96,7 @@ public void tearDown() throws Exception { | |||
| super.tearDown(); | |||
| } | |||
|
|
|||
| @Ignore | |||
There was a problem hiding this comment.
Ignoring - there is some broken functionality around the quantization state that is being fixed.
ryanbogan
approved these changes
Sep 5, 2024
naveentatikonda
approved these changes
Sep 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Introduce mode and compression param resolution Adds mode and compression based parameter resolution. With this, if a user specifies the mode and/or compression params, we will create a default configuration with the aim of meeting those hints. Currently, it does not contain support for overriding any of the parameters. This will be taken in a future commit. Signed-off-by: John Mazanec <jmazane@amazon.com> * Modify reader changes Signed-off-by: John Mazanec <jmazane@amazon.com> --------- Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit ef4922a)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Introduce mode and compression param resolution Adds mode and compression based parameter resolution. With this, if a user specifies the mode and/or compression params, we will create a default configuration with the aim of meeting those hints. Currently, it does not contain support for overriding any of the parameters. This will be taken in a future commit. Signed-off-by: John Mazanec <jmazane@amazon.com> * Modify reader changes Signed-off-by: John Mazanec <jmazane@amazon.com> --------- Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit ef4922a)
akashsha1
pushed a commit
to akashsha1/k-NN
that referenced
this pull request
Sep 16, 2024
) * Introduce mode and compression param resolution Adds mode and compression based parameter resolution. With this, if a user specifies the mode and/or compression params, we will create a default configuration with the aim of meeting those hints. Currently, it does not contain support for overriding any of the parameters. This will be taken in a future commit. Signed-off-by: John Mazanec <jmazane@amazon.com> * Modify reader changes Signed-off-by: John Mazanec <jmazane@amazon.com> --------- Signed-off-by: John Mazanec <jmazane@amazon.com> Signed-off-by: Akash Shankaran <akash.shankaran@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds mode and compression based parameter resolution. With this, if a user specifies the mode and/or compression params, we will create a default configuration with the aim of meeting those hints.
Currently, it does not contain support for overriding any of the parameters. This will be taken in a future commit.
Still working on tests, but figured it would be good to get the PR out. Heres what I still need to do:
Related Issues
#1949
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.