Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize make to reduce build time #2006

Merged

Conversation

naveentatikonda
Copy link
Member

Description

Parallelize make to reduce the build time when we are building the plugin or the JNI libraries for the first time.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@naveentatikonda
Copy link
Member Author

Running into some issues while detecting the processor count and passing it to gradle on mac and windows from github workflow. So, hardcoding them for now based on the github runners configuration
https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
Copy link
Collaborator

@navneet1v navneet1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anything that speeds up build time is great. thanks for adding this feature.

@naveentatikonda naveentatikonda merged commit bf38c2e into opensearch-project:main Aug 28, 2024
29 of 30 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 28, 2024
naveentatikonda added a commit that referenced this pull request Aug 29, 2024
(cherry picked from commit bf38c2e)

Co-authored-by: Naveen Tatikonda <navtat@amazon.com>
akashsha1 pushed a commit to akashsha1/k-NN that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants