[Backport 2.x] Block delete model requests if an index uses the model #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Block delete model requests if an index uses the model Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Add test Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Add changelog entry Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Change tests that were deleting a model in use Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Debug Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Add extra check to fix incorrect exception Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Remove println Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Change model_id search from contains to parsing response map Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Remove * import Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Combine delete model exceptions Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Move check to UpdateModelGraveyardTransportAction Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Optimize code logic Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Modify method names and throw exception in outer method Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Add test with cases for UpdateModelGraveyardTransportAction Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Fix spotless Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Refactor code and other minor optimizations Signed-off-by: Ryan Bogan <rbogan@amazon.com> --------- Signed-off-by: Ryan Bogan <rbogan@amazon.com> (cherry picked from commit 1c4a131)
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
ryanbogan
previously approved these changes
Jun 11, 2024
|
skip-changelog added because the change is going directly in the release notes |
VijayanB
previously approved these changes
Jun 11, 2024
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
ryanbogan
approved these changes
Jun 11, 2024
heemin32
approved these changes
Jun 11, 2024
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1c4a131 from #1722