Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MDS support in Notifications page in ISM #1121

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

RamakrishnaChilaka
Copy link
Collaborator

Description

This change adds multi data source selector (described in opensearch-project/OpenSearch-Dashboards#6035). This change adds MDS support to Notification page in ISM.

Issues Resolved

#982 This issue will be solved partially through this PR.

Check List

  • [✅] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ramakrishna Chilaka <ramachil@amazon.com>
Copy link
Contributor

@CaptainDredge CaptainDredge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we have a screenshot attached in issue description as well?

@SuZhou-Joe SuZhou-Joe merged commit 018b831 into opensearch-project:main Aug 19, 2024
11 of 13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 19, 2024
Signed-off-by: Ramakrishna Chilaka <ramachil@amazon.com>
(cherry picked from commit 018b831)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
skumawat2025 pushed a commit to skumawat2025/index-management-dashboards-plugin that referenced this pull request Aug 19, 2024
)

Signed-off-by: Ramakrishna Chilaka <ramachil@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 19, 2024
Signed-off-by: Ramakrishna Chilaka <ramachil@amazon.com>
(cherry picked from commit 018b831)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 19, 2024
(cherry picked from commit 018b831)

Signed-off-by: Ramakrishna Chilaka <ramachil@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants