Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newHeader for Snapshot pages #1105

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

skumawat2025
Copy link
Contributor

@skumawat2025 skumawat2025 commented Aug 13, 2024

Description

This PR tries to update the new Header for snapshot pages

Issues Resolved

[List any issues this PR will resolve]

Snapshot policy (when newHomePage is off)

  1. Snapshot policy list
    image
  2. Snapshot policy details
    image
  3. Edit policy
    image
  4. Create policy
    image

Snapshot policy (when newHomePage is on)

  1. Snapshot policy list
    image
  2. Snapshot policy details
    image
  3. Edit policy
    image
  4. Create policy
    image

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Sandeep Kumawat added 4 commits August 14, 2024 11:42
Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
@@ -139,30 +144,28 @@ export class CreateSnapshotPolicy extends MDSEnabledComponent<CreateSMPolicyProp
repoError: "",
minCountError: "",
timezoneError: "",
useNewUX: useNewUx,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps move it to a context state?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuZhou-Joe I'm of the opinion that its better to check for feature flag in main.tsx and pass it as a prop to components, we won't need context since its just a single level prop drilling. Wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just thinking we are copy

const uiSettings = getUISettings();
const useNewUx = uiSettings.get("home:useNewHomePage");

in multiple place, maybe we can consider to move that to a util or somewhere.

@SuZhou-Joe
Copy link
Member

The screenshot looks good to me.

@SuZhou-Joe SuZhou-Joe merged commit c486b61 into opensearch-project:main Aug 15, 2024
10 of 13 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1105-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c486b61345ee3411a6fa9f162180d807d5d9e8ea
# Push it to GitHub
git push --set-upstream origin backport/backport-1105-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1105-to-2.x.

skumawat2025 added a commit to skumawat2025/index-management-dashboards-plugin that referenced this pull request Aug 18, 2024
* PoC for ism

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>

* Update newHeader for snapshot policies page

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>

* new page header update for index snapshot and repository pages

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>

* triger gh workflows

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>

---------

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Co-authored-by: Sandeep Kumawat <skumwt@amazon.com>
SuZhou-Joe pushed a commit to skumawat2025/index-management-dashboards-plugin that referenced this pull request Aug 19, 2024
* PoC for ism

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>

* Update newHeader for snapshot policies page

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>

* new page header update for index snapshot and repository pages

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>

* triger gh workflows

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>

---------

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Co-authored-by: Sandeep Kumawat <skumwt@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 19, 2024
* PoC for ism



* Update newHeader for snapshot policies page



* new page header update for index snapshot and repository pages



* triger gh workflows



---------

Signed-off-by: Sandeep Kumawat <skumwt@amazon.com>
Co-authored-by: Sandeep Kumawat <skumwt@amazon.com>
@skumawat2025 skumawat2025 deleted the poc-branch branch September 4, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants