Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up various compile warnings #95

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Clean up various compile warnings #95

merged 1 commit into from
Oct 16, 2023

Conversation

dbwiddis
Copy link
Member

Description

I idon't like ⚠️ in my IDE. :)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dbwiddis
Clean up various compile warnings
3eff35e 
Signed-off-by: Daniel Widdis <widdis@gmail.com>
@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #95 (3eff35e) into main (1b856de) will increase coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main      #95      +/-   ##
============================================
+ Coverage     81.68%   81.82%   +0.14%     
  Complexity      285      285              
============================================
  Files            30       30              
  Lines          1119     1117       -2     
  Branches        125      125              
============================================
  Hits            914      914              
+ Misses          160      158       -2     
  Partials         45       45
Files Coverage Δ
...g/opensearch/flowframework/common/CommonValue.java 100.00% <ø> (+33.33%) ⬆️
.../opensearch/flowframework/common/TemplateUtil.java 100.00% <ø> (+5.55%) ⬆️

owaiskazi19
owaiskazi19 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the warnings for our IDEs too :)

@joshpalis joshpalis merged commit 9784f41 into opensearch-project:main Oct 16, 2023
11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 16, 2023
@github-actions
Clean up various compile warnings (#95)
a6ebfeb 
Signed-off-by: Daniel Widdis <widdis@gmail.com>
(cherry picked from commit 9784f41)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 16, 2023
Merged
joshpalis pushed a commit that referenced this pull request Oct 16, 2023
@opensearch-trigger-bot @github-actions
[Backport 2.x] Clean up various compile warnings (#97)
df05482 
Clean up various compile warnings (#95)


(cherry picked from commit 9784f41)

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@joshpalis joshpalis joshpalis approved these changes

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

Assignees
No one assigned
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbwiddis @owaiskazi19 @joshpalis