Run integ tests in parallel with build #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
=========================================
Coverage 81.82% 81.82%
Complexity 285 285
=========================================
Files 30 30
Lines 1117 1117
Branches 125 125
=========================================
Hits 914 914
Misses 158 158
Partials 45 45 |
Signed-off-by: Daniel Widdis <widdis@gmail.com>
joshpalis
approved these changes
Oct 16, 2023
owaiskazi19
reviewed
Oct 16, 2023
|
To discuss the 3 JDKs mentioned in the PR description. The below JDK version are needed for the respective branches/development purpose. We can run 17 on just ubuntu though. |
So this should be 17 (ubuntu only) and 20 on main, and 17 (ubuntu only) and 11 on backport? |
If we are running 11 on just backport/2.x, that way we won't be able to catch any issues on main which are not supported on JDK11. |
Signed-off-by: Daniel Widdis <widdis@gmail.com>
|
|
jackiehanyang
approved these changes
Oct 16, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
* Run integ tests in parallel with build Signed-off-by: Daniel Widdis <widdis@gmail.com> * Repo check on all runs, reduce JDK17 runs to ubuntu only Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Joshua Palis <jpalis@amazon.com> (cherry picked from commit c84321f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
added a commit
that referenced
this pull request
Oct 17, 2023
* Run integ tests in parallel with build (#94) * Run integ tests in parallel with build Signed-off-by: Daniel Widdis <widdis@gmail.com> * Repo check on all runs, reduce JDK17 runs to ubuntu only Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Joshua Palis <jpalis@amazon.com> (cherry picked from commit c84321f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Remove JDK20 from backport CI Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove the other JDK20 Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Joshua Palis <jpalis@amazon.com> Co-authored-by: Daniel Widdis <widdis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inspired by discussion on #84 (Thanks @owaiskazi19)
Removes the repo conditional on spotless and javadoc checks, so you don't need to submit the PR to get alerted about those failures.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.