Fixed testPluginInstalled failure #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
=========================================
Coverage 81.68% 81.68%
Complexity 285 285
=========================================
Files 30 30
Lines 1119 1119
Branches 125 125
=========================================
Hits 914 914
Misses 160 160
Partials 45 45 |
dbwiddis
approved these changes
Oct 13, 2023
|
was this tested on a windows machine? I see the previous PR also passed the windows CI check. Did it just pass cause we didn't have any tests? |
Previous PR's backport PR failed on 2.x windows CI. All the attempts are to fix it on 2.x |
amitgalitz
approved these changes
Oct 13, 2023
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-ai-flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/opensearch-ai-flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-92-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1b856deadeccfe0b87e572d8cfbb6909da70d1c7
# Push it to GitHub
git push --set-upstream origin backport/backport-92-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-ai-flow-framework/backport-2.xThen, create a pull request where the |
owaiskazi19
added a commit
to owaiskazi19/opensearch-ai-flow-framework
that referenced
this pull request
Oct 13, 2023
(cherry picked from commit 1b856de)
owaiskazi19
added a commit
to owaiskazi19/opensearch-ai-flow-framework
that referenced
this pull request
Oct 13, 2023
(cherry picked from commit 1b856de) Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
dbwiddis
pushed a commit
that referenced
this pull request
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another attempt to fix testPluginInstalled() test on Windows.
Issues Resolved
Another attempt for #87
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.