Fixing neural search name check for default use case integ test #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Palis <jpalis@amazon.com>
joshpalis
requested review from
dbwiddis,
owaiskazi19,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
This was referenced Mar 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
=========================================
Coverage 72.75% 72.75%
Complexity 681 681
=========================================
Files 82 82
Lines 3491 3491
Branches 279 279
=========================================
Hits 2540 2540
Misses 832 832
Partials 119 119 ☔ View full report in Codecov by Sentry. |
amitgalitz
approved these changes
Mar 22, 2024
dbwiddis
approved these changes
Mar 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
fixing neural search name Signed-off-by: Joshua Palis <jpalis@amazon.com> (cherry picked from commit 8820d89) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
fixing neural search name Signed-off-by: Joshua Palis <jpalis@amazon.com> (cherry picked from commit 8820d89) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes neural search name check in integration tests. Neural Search plugin has the name
neural-searchin their settings.gradle, however the plugin name shows up asopensearch-neural-searchIssues Resolved
#599
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.