[Backport 2.x] Adding security enabled integration tests (#400) #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding intiial security integration tests, addin test security workflow Signed-off-by: Joshua Palis <jpalis@amazon.com> * updating set up to v4 Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixing run docker image task Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixing pull and run docket Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixing pull and run docket Signed-off-by: Joshua Palis <jpalis@amazon.com> * Testing integ test if security is not available Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing non-security integ test from workflow Signed-off-by: Joshua Palis <jpalis@amazon.com> * test Signed-off-by: Joshua Palis <jpalis@amazon.com> * test Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing docker -ps Signed-off-by: Joshua Palis <jpalis@amazon.com> * Pulling in secuirty as a zipArchive dependency, installed and configured only for security y enabled clusters Signed-off-by: Joshua Palis <jpalis@amazon.com> * fixing ci Signed-off-by: Joshua Palis <jpalis@amazon.com> * using v1 Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments, using security.emabled system property instead Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding remaining read access role tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * spotless Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments, adding full access tests, fixing create workflow bug Signed-off-by: Joshua Palis <jpalis@amazon.com> * Added more APIs to full access client test Signed-off-by: Joshua Palis <jpalis@amazon.com> * updating DEVELOPER_GUIDE Signed-off-by: Joshua Palis <jpalis@amazon.com> * Updating developer guide, adding back ML Commons security system indices to security plugin configuration Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
joshpalis
requested review from
dbwiddis,
owaiskazi19,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #403 +/- ##
============================================
- Coverage 72.17% 71.79% -0.38%
+ Complexity 613 612 -1
============================================
Files 79 79
Lines 3069 3081 +12
Branches 237 238 +1
============================================
- Hits 2215 2212 -3
- Misses 752 764 +12
- Partials 102 105 +3 ☔ View full report in Codecov by Sentry. |
amitgalitz
approved these changes
Jan 13, 2024
owaiskazi19
approved these changes
Jan 13, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual Backport of #400
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.