Removing Writeable from Template #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Palis <jpalis@amazon.com>
joshpalis
requested review from
dbwiddis,
owaiskazi19,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
============================================
+ Coverage 72.80% 73.04% +0.24%
Complexity 602 602
============================================
Files 75 75
Lines 3008 2998 -10
Branches 234 233 -1
============================================
Hits 2190 2190
+ Misses 716 706 -10
Partials 102 102 ☔ View full report in Codecov by Sentry. |
owaiskazi19
approved these changes
Jan 9, 2024
dbwiddis
approved these changes
Jan 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
Removing writeable from template Signed-off-by: Joshua Palis <jpalis@amazon.com> (cherry picked from commit 815a74e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
that referenced
this pull request
Jan 9, 2024
Removing Writeable from Template (#392) Removing writeable from template (cherry picked from commit 815a74e) Signed-off-by: Joshua Palis <jpalis@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the Writeable class from the Template since it is never used
Issues Resolved
#391
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.