[Backport 2.x] Manual Back Port of #350 #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegration tests (opensearch-project#350) * Fixing local model integration test Signed-off-by: Joshua Palis <jpalis@amazon.com> * Added deploy model flag support for local model registration, added associated integration test Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixing comment Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixing deprovision workflow transport action, removing use of template, ascertaining deprovision sequence from created resources Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing rest status checks for deprovision API tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * Increasing wait time for deprovision status Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing sdeprovision status checks for model deployment tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * increasing timeout for local model registration test template Signed-off-by: Joshua Palis <jpalis@amazon.com> * Reverting timeout increase, setting ML Commons native memory threshold to 100 to avoid opening circuit breaker Signed-off-by: Joshua Palis <jpalis@amazon.com> * Passing an action listener to retryableGetMlTask Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments, preserving order of resource map Signed-off-by: Joshua Palis <jpalis@amazon.com> * Testing if a wait time after deprovisioning will mitigate circuit breaker issues Signed-off-by: Joshua Palis <jpalis@amazon.com> * Increasing mlconfig index creation wait time Signed-off-by: Joshua Palis <jpalis@amazon.com> * Combining local model registration tests into one Signed-off-by: Joshua Palis <jpalis@amazon.com> * removing resource map from deprovision workflow transport action Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixing getResourceFromDeprovisionNOde and tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * Separating out local model registration tests, using ml jvm heap memory setting instead of native memory heap setting Signed-off-by: Joshua Palis <jpalis@amazon.com> * Testing : removing second local model registration test Signed-off-by: Joshua Palis <jpalis@amazon.com> * Reducing model registration tests, testing local model registration with deployed flag, testing remote model registration with deploy step Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing suffix from simulated deploy model step Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
joshpalis
requested review from
dbwiddis,
owaiskazi19,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #372 +/- ##
============================================
- Coverage 72.55% 72.30% -0.25%
- Complexity 572 574 +2
============================================
Files 72 72
Lines 2988 3001 +13
Branches 226 230 +4
============================================
+ Hits 2168 2170 +2
- Misses 716 727 +11
Partials 104 104 ☔ View full report in Codecov by Sentry. |
amitgalitz
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual BP of #350
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.